feat(eventindexer): add get events by address/name param for community #14025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #14025 +/- ##
==========================================
- Coverage 51.99% 51.84% -0.16%
==========================================
Files 147 148 +1
Lines 3829 3854 +25
Branches 336 336
==========================================
+ Hits 1991 1998 +7
- Misses 1728 1745 +17
- Partials 110 111 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidtaikocha
approved these changes
Jun 21, 2023
dantaik
approved these changes
Jun 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some community members need a /events endpoint to query blockproposed/blockproven/blockverified events by address and name to enable some features on their node dashboard.
@wolfderechter will utilize this I believe, the endpoint works as follows:
/events?address=0xwhatever&event=BlockProposed|BlockProven|BlockVerified, will return a paginated list, to consume the following pages just make the same request with&page=2,&page=3, etc, will return the next page. Will return 100 items per page. The response has atotal_pagesproperty to see how many pages exist.